Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "native" full-text search support (SQLite), refs #1481 #1801

Merged
merged 1 commit into from Aug 18, 2016
Merged

Add "native" full-text search support (SQLite), refs #1481 #1801

merged 1 commit into from Aug 18, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Aug 18, 2016 •
edited

This PR is made in reference to: #1481

This PR addresses or contains:

  • Adds fulltext search support for the SQLite back-end
  • Adds SQLiteValueMatchConditionBuilder as adapter to generate SQLite specific FTS expression
  • Uses the same integration test q-0104 as MySQL (with minor adaptations due to difference in FTS syntax usage and expected results)
  • [0, 1] describes the SQLite FTS syntax

This PR includes:

  • Tests (unit/integration)
  • CI build passed

[0] https://www.sqlite.org/fts3.html
[1] https://www.sqlite.org/fts5.html

@mwjames mwjames added the new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour label Aug 18, 2016
@mwjames mwjames added this to the SMW 2.5 milestone Aug 18, 2016
@mwjames mwjames merged commit de419c1 into master Aug 18, 2016
@mwjames mwjames deleted the fulltext-sqlite branch August 18, 2016 17:09
@mwjames
Copy link
Contributor Author

mwjames commented Aug 18, 2016

@kghbln FYI

@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Aug 18, 2016
@mwjames mwjames mentioned this pull request Dec 18, 2016
Merged
2 tasks
@kghbln kghbln changed the title Add "native" fulltext search support (SQLite), refs #1481 Add "native" full-text search support (SQLite), refs #1481 Dec 19, 2016
@kghbln kghbln removed the wikidocu missing Code changes (mostly features) what have not yet been documented label Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour
Projects
None yet
Milestone
SMW 2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwjames @kghbln